Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/context_menus/event_page/test.js

Issue 1772513002: Add frameId to contextMenus.onClicked / onclick. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/browser/ui/app_list/extension_app_context_menu.cc ('K') | « chrome/common/extensions/api/context_menus_internal.json ('k') | chrome/test/data/extensions/context_menus/frames/test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 chrome.runtime.onInstalled.addListener(function() { 5 chrome.runtime.onInstalled.addListener(function() {
6 chrome.contextMenus.create({'id': 'item1', 'title': 'Item 1'}); 6 chrome.contextMenus.create({'id': 'item1', 'title': 'Item 1'});
7 chrome.contextMenus.create( 7 chrome.contextMenus.create(
8 {'id': 'checkbox1', 'title': 'Checkbox 1', 'type': 'checkbox'}); 8 {'id': 'checkbox1', 'title': 'Checkbox 1', 'type': 'checkbox'});
9 }); 9 });
10 10
11 chrome.contextMenus.onClicked.addListener(function(info, tab) { 11 chrome.contextMenus.onClicked.addListener(function(info, tab) {
12 chrome.test.assertTrue(tab.id != null); 12 chrome.test.assertTrue(tab.id != null);
13 chrome.test.assertEq(0, info.frameId); // 0 = main frame
13 chrome.test.sendMessage("onClicked fired for " + info.menuItemId); 14 chrome.test.sendMessage("onClicked fired for " + info.menuItemId);
14 }); 15 });
OLDNEW
« chrome/browser/ui/app_list/extension_app_context_menu.cc ('K') | « chrome/common/extensions/api/context_menus_internal.json ('k') | chrome/test/data/extensions/context_menus/frames/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698