Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1772503002: Revert of [mojo-bindings] Use Watch API instead of MessagePumpMojo (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
jam, yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo-bindings] Use Watch API instead of MessagePumpMojo (patchset #12 id:210001 of https://codereview.chromium.org/1759783003/ ) Reason for revert: one more time. mojo_app_tests flake Original issue's description: > [mojo-bindings] Use Watch API instead of MessagePumpMojo > > This removes the C++ bindings dependency on MessagePumpMojo, > consuming the new Watch API instead. > > For convenience a new mojo::Watcher is added to the public > Mojo C++ API library, and this is used by Connector. > > BUG=590495 > R=yzshen@chromium.org > TBR=blundell@chromium.org for rename affecting components/message_port.gypi > TBR=jam@chromium.org - added a missing header to new url tests > > Committed: https://crrev.com/d06373e7cd8b4ad725ed5c64c958f2de13585add > Cr-Commit-Position: refs/heads/master@{#379402} > > Committed: https://crrev.com/2cdb2f677c68f06b3bc54cd40f000ab961a09bbb > Cr-Commit-Position: refs/heads/master@{#379463} TBR=jam@chromium.org,yzshen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590495 Committed: https://chromium.googlesource.com/chromium/src/+/554355993ee16fa592a450f2dd00729b69988dc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -485 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/message_port.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_public.gyp View 3 chunks +5 lines, -8 lines 0 comments Download
M mojo/mojo_variables.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 6 chunks +25 lines, -18 lines 0 comments Download
M mojo/public/cpp/system/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/system/tests/watcher_unittest.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D mojo/public/cpp/system/watcher.h View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/public/cpp/system/watcher.cc View 1 chunk +0 lines, -134 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 1 chunk +1 line, -7 lines 0 comments Download
M url/mojo/url_gurl_struct_traits_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of [mojo-bindings] Use Watch API instead of MessagePumpMojo
4 years, 9 months ago (2016-03-06 17:23:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772503002/1
4 years, 9 months ago (2016-03-06 17:23:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772503002/1
4 years, 9 months ago (2016-03-06 17:31:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/554355993ee16fa592a450f2dd00729b69988dc7 Cr-Commit-Position: refs/heads/master@{#379492}
4 years, 9 months ago (2016-03-06 17:32:26 UTC) #5
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-06 17:33:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
554355993ee16fa592a450f2dd00729b69988dc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698