Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1772493002: SkPDF: AutoTUnref<T> changes in use (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: AutoTUnref<T> changes in use ::detach() -> ::release() ::operator T*() -> ::get() This makes all use of AutoTUnref work the same as sk_sp. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772493002 Committed: https://skia.googlesource.com/skia/+/fcad44bbb1e0384620e7b738a0f5904c940a6861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -82 lines) Patch
M src/doc/SkDocument_PDF.cpp View 10 chunks +15 lines, -15 lines 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/pdf/SkPDFCanon.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 11 chunks +15 lines, -15 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 13 chunks +20 lines, -20 lines 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
hal.canary
ptal
4 years, 9 months ago (2016-03-06 17:19:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772493002/1
4 years, 9 months ago (2016-03-06 21:43:55 UTC) #5
bungeman-skia
lgtm, but is there any reason not to change the type of all the affected ...
4 years, 9 months ago (2016-03-06 21:48:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-06 21:53:06 UTC) #8
hal.canary
On 2016/03/06 21:48:34, bungeman1 wrote: > lgtm, but is there any reason not to change ...
4 years, 9 months ago (2016-03-06 22:45:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772493002/1
4 years, 9 months ago (2016-03-06 22:45:55 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-06 22:47:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fcad44bbb1e0384620e7b738a0f5904c940a6861

Powered by Google App Engine
This is Rietveld 408576698