src/core/SkReadBuffer.h - Issue 1772463002: use Make instead of Create to return a shared shader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkReadBuffer.h

Issue 1772463002: use Make instead of Create to return a shared shader (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: partial update of skia call-sites Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkReadBuffer.h

diff --git a/src/core/SkReadBuffer.h b/src/core/SkReadBuffer.h

index b9b30944fff0cc71b2c14d6526ef062e79f201bb..5db9f4644d46b2bfc9d5dc5fa103f26125455705 100644

--- a/src/core/SkReadBuffer.h

+++ b/src/core/SkReadBuffer.h

@@ -136,7 +136,7 @@ public:

SkMaskFilter* readMaskFilter() { return this->readFlattenable<SkMaskFilter>(); }

SkPathEffect* readPathEffect() { return this->readFlattenable<SkPathEffect>(); }

SkRasterizer* readRasterizer() { return this->readFlattenable<SkRasterizer>(); }

- SkShader* readShader() { return this->readFlattenable<SkShader>(); }

+ sk_sp<SkShader> readShader() { return sk_sp<SkShader>(this->readFlattenable<SkShader>()); }

SkXfermode* readXfermode() { return this->readFlattenable<SkXfermode>(); }

/**