samplecode/SampleXfermodesBlur.cpp - Issue 1772463002: use Make instead of Create to return a shared shader - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(524)

My Issues | Starred Open | Closed | All

Unified Diff: samplecode/SampleXfermodesBlur.cpp

Issue 1772463002: use Make instead of Create to return a shared shader (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: partial update of skia call-sites Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« samplecode/SampleShaders.cpp ('K') | « samplecode/SampleXfer.cpp ('k') | src/animator/SkDrawGradient.cpp » ('j') | src/animator/SkDrawGradient.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: samplecode/SampleXfermodesBlur.cpp

diff --git a/samplecode/SampleXfermodesBlur.cpp b/samplecode/SampleXfermodesBlur.cpp

index f995c6aa7ea1159195ba2dfbd49be8e9a7835378..63c90fea15507a7470ee96a9fa5b1b08113493af 100644

--- a/samplecode/SampleXfermodesBlur.cpp

+++ b/samplecode/SampleXfermodesBlur.cpp

@@ -150,10 +150,8 @@ protected:

const SkScalar h = SkIntToScalar(H);

SkMatrix m;

m.setScale(SkIntToScalar(6), SkIntToScalar(6));

- SkShader* s = SkShader::CreateBitmapShader(fBG,

- SkShader::kRepeat_TileMode,

- SkShader::kRepeat_TileMode,

- &m);

+ auto s = SkShader::MakeBitmapShader(fBG, SkShader::kRepeat_TileMode,

+ SkShader::kRepeat_TileMode, &m);

SkPaint labelP;

labelP.setAntiAlias(true);

« samplecode/SampleShaders.cpp ('K') | « samplecode/SampleXfer.cpp ('k') | src/animator/SkDrawGradient.cpp » ('j') | src/animator/SkDrawGradient.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698