Source/core/html/HTMLMediaElement.h - Issue 177243018: Prevent 'removetrack' events from firing when all inband text tracks are removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 177243018: Prevent 'removetrack' events from firing when all inband text tracks are removed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix expectations Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/track/track-remove-track-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 3141ec62f3fa359a74c88b1118b9414d2550d465..4a978e0cc60f139b7c8f07e631a20652d6b90542 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -187,11 +187,13 @@ public:

CueList currentlyActiveCues() const { return m_currentlyActiveCues; }

void addTextTrack(TextTrack*);

- void removeTextTrack(TextTrack*);

- void removeAllInbandTracks();

+ void removeTextTrack(TextTrack*, bool scheduleEvent);

adamk 2014/02/26 00:45:32 Please make this argument an enum so that the call

void closeCaptionTracksChanged();

void notifyMediaPlayerOfTextTrackChanges();

+ // Implements the "forget the media element's media-resource-specific tracks" algorithm in the HTML5 spec.

+ void forgetResourceSpecificTracks();

void didAddTrackElement(HTMLTrackElement*);

void didRemoveTrackElement(HTMLTrackElement*);

« no previous file with comments | « LayoutTests/media/track/track-remove-track-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')