Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 177243007: Fixing the GCMStoreImplTest.GetNextPersistentId on Windows (Closed)

Created:
6 years, 10 months ago by fgorski
Modified:
6 years, 10 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixing the GCMStoreImplTest.GetNextPersistentId on Windows Problem: It seems that consecutive calls to base::Time::Now().ToInternalValue() might yield the same outcome multiple times in a row, which is not suitable for producing unique IDs for testing. Fix: Persist a starting value based on current time and then increment it with every call. BUG=345118 R=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
fgorski
PTAL
6 years, 10 months ago (2014-02-24 21:27:41 UTC) #1
Nicolas Zea
Good find, LGTM
6 years, 10 months ago (2014-02-24 21:34:27 UTC) #2
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 10 months ago (2014-02-24 22:21:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
6 years, 10 months ago (2014-02-24 22:23:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 23:03:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=269193
6 years, 10 months ago (2014-02-24 23:03:14 UTC) #6
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 10 months ago (2014-02-25 00:06:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
6 years, 10 months ago (2014-02-25 00:11:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
6 years, 10 months ago (2014-02-25 01:45:18 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 04:56:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 04:56:24 UTC) #11
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 10 months ago (2014-02-25 05:07:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
6 years, 10 months ago (2014-02-25 05:11:32 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 05:16:04 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 05:16:05 UTC) #15
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 10 months ago (2014-02-25 18:14:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
6 years, 10 months ago (2014-02-25 18:18:35 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 18:23:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 18:23:18 UTC) #19
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 10 months ago (2014-02-25 18:53:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
6 years, 10 months ago (2014-02-25 18:58:12 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 19:01:49 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 19:01:50 UTC) #23
fgorski
6 years, 10 months ago (2014-02-25 19:44:24 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 manually as r253229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698