|
|
Created:
6 years, 10 months ago by fgorski Modified:
6 years, 10 months ago Reviewers:
Nicolas Zea CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFixing the GCMStoreImplTest.GetNextPersistentId on Windows
Problem:
It seems that consecutive calls to base::Time::Now().ToInternalValue() might
yield the same outcome multiple times in a row, which is not suitable for
producing unique IDs for testing.
Fix:
Persist a starting value based on current time and then increment it with
every call.
BUG=345118
R=zea@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253229
Patch Set 1 #
Messages
Total messages: 24 (0 generated)
PTAL
Good find, LGTM
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/177243007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
Message was sent while issue was closed.
Committed patchset #1 manually as r253229 (presubmit successful). |