Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 177243006: Add gbillock@ to website settings OWNERS files. (Closed)

Created:
6 years, 10 months ago by markusheintz_
Modified:
6 years, 10 months ago
Reviewers:
tfarina, Greg Billock
CC:
chromium-reviews, tfarina, groby-ooo-7-16, leng
Visibility:
Public.

Description

Add gbillock@ to website settings OWNERS files. BUG=none NOTRY=true R=gbillock@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/gtk/website_settings/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
markusheintz_
PTAL
6 years, 10 months ago (2014-02-24 16:45:10 UTC) #1
Greg Billock
lgtm
6 years, 10 months ago (2014-02-24 17:25:20 UTC) #2
markusheintz_
The CQ bit was checked by markusheintz@chromium.org
6 years, 10 months ago (2014-02-24 17:31:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-24 17:32:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 18:53:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268860
6 years, 10 months ago (2014-02-24 18:53:46 UTC) #6
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-24 19:40:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-24 19:43:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-24 20:30:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-24 21:14:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 22:58:14 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=269197
6 years, 10 months ago (2014-02-24 22:58:15 UTC) #12
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-24 23:02:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-24 23:05:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-25 01:36:46 UTC) #15
tfarina
This does not need trybots. It is just wasting machine time. Why not put NOTRY=true ...
6 years, 10 months ago (2014-02-25 02:08:25 UTC) #16
Greg Billock
The CQ bit was unchecked by gbillock@chromium.org
6 years, 10 months ago (2014-02-25 05:06:58 UTC) #17
Greg Billock
On 2014/02/25 02:08:25, tfarina wrote: > This does not need trybots. It is just wasting ...
6 years, 10 months ago (2014-02-25 05:07:27 UTC) #18
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-25 05:07:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-25 07:33:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-25 09:10:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/177243006/1
6 years, 10 months ago (2014-02-25 09:28:31 UTC) #22
markusheintz_
The CQ bit was unchecked by markusheintz@chromium.org
6 years, 10 months ago (2014-02-25 09:49:42 UTC) #23
markusheintz_
6 years, 10 months ago (2014-02-25 09:51:44 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 manually as r253103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698