Source/core/page/PageSerializer.cpp - Issue 177243005: [SavePage] Do not save images with errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageSerializer.cpp

Issue 177243005: [SavePage] Do not save images with errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding Test files Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/PageSerializer.cpp

diff --git a/Source/core/page/PageSerializer.cpp b/Source/core/page/PageSerializer.cpp

index 7f31c9c055639726f0477a0e03fa69a8af25ee07..c759769d5dfa1bc069a2c1f51b7ead4c424cf0fc 100644

--- a/Source/core/page/PageSerializer.cpp

+++ b/Source/core/page/PageSerializer.cpp

@@ -314,7 +314,7 @@ void PageSerializer::addImageToResources(ImageResource* image, RenderObject* ima

if (!shouldAddURL(url))

return;

- if (!image || image->image() == Image::nullImage())

+ if (!image || image->image() == Image::nullImage() || image->errorOccurred())

return;

RefPtr<SharedBuffer> data = imageRenderer ? image->imageForRenderer(imageRenderer)->data() : 0;