Issue 177243005: [SavePage] Do not save images with errors

Issue 177243005: [SavePage] Do not save images with errors (Closed)

Created:
6 years, 9 months ago by RashmiVijay

Modified:
6 years, 9 months ago

Reviewers:
abarth-chromium, ojan

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

[SavePage] Do not save images with errors In this page,while saving the page if images with load error/decode error are saved, while rendering the mhtml page the broken images are shown in place of those images. BUG=346254 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169616

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
M	Source/core/page/PageSerializer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/WebPageNewSerializerTest.cpp	View	1 2 3	1 chunk	+24 lines, -0 lines	0 comments	Download
A	Source/web/tests/data/pageserializer/error_image.png	View	1 2	Binary file		0 comments	Download
A	Source/web/tests/data/pageserializer/page_with_img_error.html	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 20 (0 generated)

RashmiVijay

I do have a query on testing the usecase - How do I validate the ...

6 years, 9 months ago (2014-02-27 06:54:49 UTC) #4

abarth-chromium

Take a look at how the other mhtml tests work. Generally, I think they use ...

6 years, 9 months ago (2014-02-28 06:18:05 UTC) #5