Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: src/parsing/parser-base.h

Issue 1772423002: Don't do any special normalization if a boilerplate contains function literals. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/parser-base.h
diff --git a/src/parsing/parser-base.h b/src/parsing/parser-base.h
index 129ce0d3875021c2f8c3c8d33214dfc6e87bdfab..ef616ddd86a668f90a48fd0ca9ee2aec5adea3ff 100644
--- a/src/parsing/parser-base.h
+++ b/src/parsing/parser-base.h
@@ -1820,7 +1820,6 @@ typename ParserBase<Traits>::ExpressionT ParserBase<Traits>::ParseObjectLiteral(
typename Traits::Type::PropertyList properties =
this->NewPropertyList(4, zone_);
int number_of_boilerplate_properties = 0;
- bool has_function = false;
bool has_computed_names = false;
ObjectLiteralChecker checker(this);
@@ -1845,8 +1844,7 @@ typename ParserBase<Traits>::ExpressionT ParserBase<Traits>::ParseObjectLiteral(
// Mark top-level object literals that contain function literals and
adamk 2016/03/08 19:56:49 This is probably the comment that gave me that ide
// pretenure the literal so it can be added as a constant function
// property. (Parser only.)
- this->CheckFunctionLiteralInsideTopLevelObjectLiteral(scope_, property,
- &has_function);
+ this->CheckFunctionLiteralInsideTopLevelObjectLiteral(scope_, property);
// Count CONSTANT or COMPUTED properties to maintain the enumeration order.
if (!has_computed_names && this->IsBoilerplateProperty(property)) {
@@ -1873,7 +1871,6 @@ typename ParserBase<Traits>::ExpressionT ParserBase<Traits>::ParseObjectLiteral(
return factory()->NewObjectLiteral(properties,
literal_index,
number_of_boilerplate_properties,
- has_function,
pos);
}
« src/parsing/parser.h ('K') | « src/parsing/parser.h ('k') | src/parsing/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698