src/full-codegen/full-codegen.cc - Issue 1772423002: Don't do any special normalization if a boilerplate contains function literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1772423002: Don't do any special normalization if a boilerplate contains function literals. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 517d395e1af4c8cf15128ba721dd62061cbf9712..052a83a6574584df8fbbcbe0a21fc5cbfa0e4ae6 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -1508,8 +1508,7 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {

EmitClassDefineProperties(lit);

- // Set both the prototype and constructor to have fast properties, and also

- // freeze them in strong mode.

+ // Set constructor to have fast properties.

CallRuntimeWithOperands(Runtime::kFinalizeClassDefinition);

if (lit->class_variable_proxy() != nullptr) {

« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | src/parsing/parser.h » ('J')