[Interpreter] Log code-creation events for bytecode handlers.

[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/8447072d605f08f7b2c3f3415891648782d55c35
Cr-Commit-Position: refs/heads/master@{#34631}

[Stefano Sanfilippo, 2016-03-08 15:56:48]

ssanfilippo@chromium.org changed reviewers:
+ mstarzinger@chromium.org, oth@chromium.org, rmcilroy@chromium.org,
yangguo@chromium.org

[Stefano Sanfilippo, 2016-03-08 16:04:21]

https://codereview.chromium.org/1772403002/diff/1/src/log.h
File src/log.h (right):

https://codereview.chromium.org/1772403002/diff/1/src/log.h#newcode85
src/log.h:85: #define LOG_EVENTS_AND_TAGS_LIST(V)                               
      \
git cl format did this, sorry.

[Stefano Sanfilippo, 2016-03-08 16:16:14]

Description was changed from

==========
[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-03-08 16:16:14]

ssanfilippo@chromium.org changed reviewers:
- mstarzinger@chromium.org, oth@chromium.org

[Stefano Sanfilippo, 2016-03-08 16:17:16]

ssanfilippo@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-03-08 16:21:20]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 16:21:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772403002/1

[rmcilroy, 2016-03-08 16:21:57]

Looks good from my point of view with two comments. I'll let Yang and / or Michi
approve.

https://codereview.chromium.org/1772403002/diff/1/src/interpreter/interpreter.h
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/1772403002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.h:23: class Logger;
unnecessary

https://codereview.chromium.org/1772403002/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/1772403002/diff/1/src/log.cc#newcode1605
src/log.cc:1605: void Logger::LogBytecodeHandlers() {
You should probably guard on FLAG_ignition so this only does the logging when
--ignition is passed.

[commit-bot: I haz the power, 2016-03-08 16:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 16:35:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Stefano Sanfilippo, 2016-03-08 17:22:29]

https://codereview.chromium.org/1772403002/diff/1/src/interpreter/interpreter.h
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/1772403002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.h:23: class Logger;
On 2016/03/08 16:21:57, rmcilroy wrote:
> unnecessary

Done.

https://codereview.chromium.org/1772403002/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/1772403002/diff/1/src/log.cc#newcode1605
src/log.cc:1605: void Logger::LogBytecodeHandlers() {
On 2016/03/08 16:21:57, rmcilroy wrote:
> You should probably guard on FLAG_ignition so this only does the logging when
> --ignition is passed.

Done.

[Stefano Sanfilippo, 2016-03-08 17:22:51]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 17:22:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772403002/20001

[commit-bot: I haz the power, 2016-03-08 18:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 18:10:16]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-03-09 13:02:18]

lgtm once comment is addressed.

https://codereview.chromium.org/1772403002/diff/20001/src/snapshot/code-seria...
File src/snapshot/code-serializer.cc (right):

https://codereview.chromium.org/1772403002/diff/20001/src/snapshot/code-seria...
src/snapshot/code-serializer.cc:74: case Code::BYTECODE_HANDLER:
Please move this to the CHECK(false) cases above. This cannot and must not
happen. The code cache must not contain any references directly to the bytecode
handlers.

[Stefano Sanfilippo, 2016-03-09 14:41:44]

https://codereview.chromium.org/1772403002/diff/20001/src/snapshot/code-seria...
File src/snapshot/code-serializer.cc (right):

https://codereview.chromium.org/1772403002/diff/20001/src/snapshot/code-seria...
src/snapshot/code-serializer.cc:74: case Code::BYTECODE_HANDLER:
On 2016/03/09 13:02:18, Yang wrote:
> Please move this to the CHECK(false) cases above. This cannot and must not
> happen. The code cache must not contain any references directly to the
bytecode
> handlers.

Done.

[Stefano Sanfilippo, 2016-03-09 14:42:29]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 14:42:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772403002/40001

[commit-bot: I haz the power, 2016-03-09 15:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 15:04:51]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-03-09 16:02:46]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 16:02:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772403002/60001

[commit-bot: I haz the power, 2016-03-09 16:31:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 16:31:48]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-03-09 16:34:18]

The CQ bit was checked by ssanfilippo@chromium.org

[Stefano Sanfilippo, 2016-03-09 16:34:18]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1772403002/#ps60001
(title: "Rebasing before committing.")

[commit-bot: I haz the power, 2016-03-09 16:34:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772403002/60001

[commit-bot: I haz the power, 2016-03-09 16:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 16:37:20]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12114)

[rmcilroy, 2016-03-09 16:47:53]

LGTM, thanks.

[Stefano Sanfilippo, 2016-03-09 16:49:00]

The CQ bit was checked by ssanfilippo@chromium.org

[commit-bot: I haz the power, 2016-03-09 16:49:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772403002/60001

[commit-bot: I haz the power, 2016-03-09 16:51:07]

Description was changed from

==========
[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-03-09 16:51:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-09 16:52:25]

Description was changed from

==========
[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Log code-creation events for bytecode handlers.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/8447072d605f08f7b2c3f3415891648782d55c35
Cr-Commit-Position: refs/heads/master@{#34631}
==========

[commit-bot: I haz the power, 2016-03-09 16:52:26]

Patchset 4 (id:??) landed as
https://crrev.com/8447072d605f08f7b2c3f3415891648782d55c35
Cr-Commit-Position: refs/heads/master@{#34631}