Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: Source/bindings/scripts/idl_reader.py

Issue 177233006: Merge idl_definitions_builder.py into idl_definitions.py (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased (correctly) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/idl_definitions_builder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/idl_reader.py
diff --git a/Source/bindings/scripts/idl_reader.py b/Source/bindings/scripts/idl_reader.py
index f7cf553203016574eb0fba134f33ad1d40b3501a..0aa4e88e24d805cbe528812629fb9db693185ee6 100644
--- a/Source/bindings/scripts/idl_reader.py
+++ b/Source/bindings/scripts/idl_reader.py
@@ -28,10 +28,10 @@
"""Read an IDL file or complete IDL interface, producing an IdlDefinitions object."""
-import os.path
+import os
import blink_idl_parser
-import idl_definitions_builder
+from idl_definitions import IdlDefinitions
import idl_validator
import interface_dependency_resolver
@@ -64,7 +64,9 @@ class IdlReader(object):
def read_idl_file(self, idl_filename):
"""Returns an IdlDefinitions object for an IDL file, without any dependencies."""
ast = blink_idl_parser.parse_file(self.parser, idl_filename)
- definitions = idl_definitions_builder.build_idl_definitions_from_ast(ast)
+ if not ast:
+ raise Exception('Failed to parse %s' % idl_filename)
+ definitions = IdlDefinitions(ast)
if not self.extended_attribute_validator:
return definitions
« no previous file with comments | « Source/bindings/scripts/idl_definitions_builder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698