Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 1772323002: Properly disable tests under Mac ASAN. (Closed)

Created:
4 years, 9 months ago by benwells
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, blink-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly disable tests under Mac ASAN. An attempt was made to disable the tests before but due to bad macro expansion all it did was mangle the name. TBR=thestig@chromium.org BUG=592771 Committed: https://crrev.com/6536c52c05e9fec32516833e81621dac64fbbeff Cr-Commit-Position: refs/heads/master@{#379813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 23 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
i think this is right... i feel dumb now :/
4 years, 9 months ago (2016-03-08 10:18:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772323002/1
4 years, 9 months ago (2016-03-08 10:18:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 12:25:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6536c52c05e9fec32516833e81621dac64fbbeff Cr-Commit-Position: refs/heads/master@{#379813}
4 years, 9 months ago (2016-03-08 12:27:20 UTC) #6
bokan
4 years, 9 months ago (2016-03-11 20:45:17 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1790683002/ by bokan@chromium.org.

The reason for reverting is: Fixed in r380135..

Powered by Google App Engine
This is Rietveld 408576698