CORS-RFC1918: Teach appcache responses to passthrough their socket address.

CORS-RFC1918: Teach appcache responses to passthrough their socket address.

In order to do the right thing for external requests and preflights, we
need to teach AppCacheURLRequestJob to passthrough the IP address of the
cached request. This is especially important for main resources, as those
control whether or not preflights are necessary.

This patch overrides the default 'GetSocketAddress' method to pass through
the socket address stored along with the AppCacheEntry object, and ensures
that the socket address is propegated for synchronous requests. Layout
tests verify that this results in a main resource whose
'document.addressSpace' is accurate.

BUG=591672
Committed: https://crrev.com/b035ad2b4894c007b5580c8da151dca8ad550975
Cr-Commit-Position: refs/heads/master@{#379805}

[Mike West, 2016-03-08 09:41:07]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2016-03-08 09:41:08]

Mind taking a look at this, Jochen? It introduces basically no behavioral change
in AppCache, just wiring up the existing `http_info()` method to override
`URLRequestJob`'s `GetSocketAddress()` method, and ensuring that the socket
address is passed through synchronous requests in `ResourceDispatcher`.

WDYT?

-mike

[jochen (gone - plz use gerrit), 2016-03-08 09:42:18]

lgtm

[Mike West, 2016-03-08 10:26:35]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-03-08 10:26:35]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1772303002/#ps20001
(title: "Test.")

[commit-bot: I haz the power, 2016-03-08 10:26:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772303002/20001

[commit-bot: I haz the power, 2016-03-08 10:59:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-08 11:00:41]

Description was changed from

==========
CORS-RFC1918: Teach appcache responses to passthrough their socket address.

In order to do the right thing for external requests and preflights, we
need to teach AppCacheURLRequestJob to passthrough the IP address of the
cached request. This is especially important for main resources, as those
control whether or not preflights are necessary.

This patch overrides the default 'GetSocketAddress' method to pass through
the socket address stored along with the AppCacheEntry object, and ensures
that the socket address is propegated for synchronous requests. Layout
tests verify that this results in a main resource whose
'document.addressSpace' is accurate.

BUG=591672
==========

to

==========
CORS-RFC1918: Teach appcache responses to passthrough their socket address.

In order to do the right thing for external requests and preflights, we
need to teach AppCacheURLRequestJob to passthrough the IP address of the
cached request. This is especially important for main resources, as those
control whether or not preflights are necessary.

This patch overrides the default 'GetSocketAddress' method to pass through
the socket address stored along with the AppCacheEntry object, and ensures
that the socket address is propegated for synchronous requests. Layout
tests verify that this results in a main resource whose
'document.addressSpace' is accurate.

BUG=591672

Committed: https://crrev.com/b035ad2b4894c007b5580c8da151dca8ad550975
Cr-Commit-Position: refs/heads/master@{#379805}
==========

[commit-bot: I haz the power, 2016-03-08 11:00:43]

Patchset 2 (id:??) landed as
https://crrev.com/b035ad2b4894c007b5580c8da151dca8ad550975
Cr-Commit-Position: refs/heads/master@{#379805}