Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 17723002: Remove skip_static_calls_ as it uses an obsolete way to check for uncalled static calls. Will be re… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_mips.cc
===================================================================
--- runtime/vm/flow_graph_compiler_mips.cc (revision 24431)
+++ runtime/vm/flow_graph_compiler_mips.cc (working copy)
@@ -1409,12 +1409,13 @@
}
-void FlowGraphCompiler::EmitStaticCall(const Function& function,
- const Array& arguments_descriptor,
- intptr_t argument_count,
- intptr_t deopt_id,
- intptr_t token_pos,
- LocationSummary* locs) {
+void FlowGraphCompiler::EmitOptimizedStaticCall(
+ const Function& function,
+ const Array& arguments_descriptor,
+ intptr_t argument_count,
+ intptr_t deopt_id,
+ intptr_t token_pos,
+ LocationSummary* locs) {
__ TraceSimMsg("StaticCall");
__ LoadObject(S4, arguments_descriptor);
// Do not use the code from the function, but let the code be patched so that
@@ -1422,7 +1423,7 @@
GenerateDartCall(deopt_id,
token_pos,
&StubCode::CallStaticFunctionLabel(),
- PcDescriptors::kFuncCall,
+ PcDescriptors::kOptStaticCall,
locs);
AddStaticCallTarget(function);
__ Drop(argument_count);
@@ -1447,7 +1448,7 @@
GenerateDartCall(deopt_id,
token_pos,
&StubCode::UnoptimizedStaticCallLabel(),
- PcDescriptors::kFuncCall,
+ PcDescriptors::kUnoptStaticCall,
locs);
__ Drop(argument_count);
}
@@ -1608,6 +1609,7 @@
intptr_t deopt_id,
intptr_t token_index,
LocationSummary* locs) {
+ ASSERT(is_optimizing());
ASSERT(!ic_data.IsNull() && (ic_data.NumberOfChecks() > 0));
Label match_found;
const intptr_t len = ic_data.NumberOfChecks();
@@ -1634,7 +1636,7 @@
GenerateDartCall(deopt_id,
token_index,
&StubCode::CallStaticFunctionLabel(),
- PcDescriptors::kFuncCall,
+ PcDescriptors::kOptStaticCall,
locs);
const Function& function = *sorted[i].target;
AddStaticCallTarget(function);

Powered by Google App Engine
This is Rietveld 408576698