Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1772293004: Improve ChromeVox incremental search experience. (Closed)

Created:
4 years, 9 months ago by dmazzoni
Modified:
4 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve ChromeVox incremental search experience. * Add CSS so that search box is centered in the panel and styled to match * Hide caption panel while search box is open, restore it when it closes * Clear the previous search when the search box loses focus BUG=513714 Committed: https://crrev.com/44996d205c2a3b921eb4848f610b2cf30b74432b Cr-Commit-Position: refs/heads/master@{#379941}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css View 2 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 5 chunks +44 lines, -1 line 2 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
dmazzoni
4 years, 9 months ago (2016-03-08 21:12:31 UTC) #2
David Tseng
lgtm Thanks for the fixes/visuals. https://codereview.chromium.org/1772293004/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js (right): https://codereview.chromium.org/1772293004/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js#newcode503 chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:503: Panel.searchInput_.value = ''; I ...
4 years, 9 months ago (2016-03-08 21:28:51 UTC) #3
dmazzoni
https://codereview.chromium.org/1772293004/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js (right): https://codereview.chromium.org/1772293004/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js#newcode503 chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:503: Panel.searchInput_.value = ''; On 2016/03/08 21:28:51, David Tseng wrote: ...
4 years, 9 months ago (2016-03-08 21:34:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772293004/1
4 years, 9 months ago (2016-03-08 21:35:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 22:28:10 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 22:29:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44996d205c2a3b921eb4848f610b2cf30b74432b
Cr-Commit-Position: refs/heads/master@{#379941}

Powered by Google App Engine
This is Rietveld 408576698