Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1772293002: Revert of [interpreter, debugger] add some missing statement positions. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter, debugger] add some missing statement positions. (patchset #1 id:1 of https://codereview.chromium.org/1770773002/ ) Reason for revert: failing tests with ignition. Original issue's description: > [interpreter, debugger] add some missing statement positions. > > R=rmcilroy@chromium.org, vogelheim@chromium.org > BUG=v8:4690 > LOG=N > > Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e > Cr-Commit-Position: refs/heads/master@{#34569} TBR=rmcilroy@chromium.org,vogelheim@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4690 Committed: https://crrev.com/059c163695a34ab16cfc82ca3a988f4db0fae1c0 Cr-Commit-Position: refs/heads/master@{#34570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 11 chunks +0 lines, -14 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
Created Revert of [interpreter, debugger] add some missing statement positions.
4 years, 9 months ago (2016-03-08 08:28:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772293002/1
4 years, 9 months ago (2016-03-08 08:29:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 08:29:13 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 08:30:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/059c163695a34ab16cfc82ca3a988f4db0fae1c0
Cr-Commit-Position: refs/heads/master@{#34570}

Powered by Google App Engine
This is Rietveld 408576698