Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/browser/android/data_usage/data_use_matcher_unittest.cc

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_matcher_unittest.cc
diff --git a/chrome/browser/android/data_usage/data_use_matcher_unittest.cc b/chrome/browser/android/data_usage/data_use_matcher_unittest.cc
index 318e5194996b122b5f97c3d9fe991f1a03820ace..df2631bea2c682ab5af2698b8f18f800a858b1f6 100644
--- a/chrome/browser/android/data_usage/data_use_matcher_unittest.cc
+++ b/chrome/browser/android/data_usage/data_use_matcher_unittest.cc
@@ -16,7 +16,7 @@
#include "base/test/histogram_tester.h"
#include "base/time/tick_clock.h"
#include "base/time/time.h"
-#include "chrome/browser/android/data_usage/external_data_use_observer.h"
+#include "chrome/browser/android/data_usage/external_data_use_observer_bridge.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -56,6 +56,14 @@ class NowTestTickClock : public base::TickClock {
DISALLOW_COPY_AND_ASSIGN(NowTestTickClock);
};
+class TestExternalDataUseObserverBridge
+ : public chrome::android::ExternalDataUseObserverBridge {
+ public:
+ TestExternalDataUseObserverBridge() {}
+ void FetchMatchingRules() const override {}
+ void ShouldRegisterAsDataUseObserver(bool should_register) const override{};
+};
+
} // namespace
namespace chrome {
@@ -68,10 +76,10 @@ class DataUseMatcherTest : public testing::Test {
public:
DataUseMatcherTest()
: thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
+ external_data_use_observer_bridge_(
+ new TestExternalDataUseObserverBridge()),
data_use_matcher_(base::WeakPtr<DataUseTabModel>(),
- content::BrowserThread::GetMessageLoopProxyForThread(
- content::BrowserThread::IO),
- base::WeakPtr<ExternalDataUseObserver>(),
+ external_data_use_observer_bridge_.get(),
base::TimeDelta::FromSeconds(
kDefaultMatchingRuleExpirationDurationSeconds)) {}
@@ -93,6 +101,7 @@ class DataUseMatcherTest : public testing::Test {
private:
content::TestBrowserThreadBundle thread_bundle_;
+ scoped_ptr<ExternalDataUseObserverBridge> external_data_use_observer_bridge_;
DataUseMatcher data_use_matcher_;
DISALLOW_COPY_AND_ASSIGN(DataUseMatcherTest);
};
« no previous file with comments | « chrome/browser/android/data_usage/data_use_matcher.cc ('k') | chrome/browser/android/data_usage/data_use_tab_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698