Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer_bridge.h

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tbansal comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/external_data_use_observer_bridge.h
diff --git a/chrome/browser/android/data_usage/external_data_use_observer_bridge.h b/chrome/browser/android/data_usage/external_data_use_observer_bridge.h
index da3b8f12ce33c4ac042e210fc5322f98cc120389..2cbcfcf569f265fc56113cc9b1858ff8944649ef 100644
--- a/chrome/browser/android/data_usage/external_data_use_observer_bridge.h
+++ b/chrome/browser/android/data_usage/external_data_use_observer_bridge.h
@@ -39,7 +39,7 @@ class ExternalDataUseObserver;
class ExternalDataUseObserverBridge {
public:
ExternalDataUseObserverBridge();
- ~ExternalDataUseObserverBridge();
+ virtual ~ExternalDataUseObserverBridge();
// Initializes |this| on UI thread by constructing the
// |j_external_data_use_observer_|, and fetches matching rules from
@@ -51,7 +51,7 @@ class ExternalDataUseObserverBridge {
// Fetches matching rules from Java. Returns result asynchronously via
// FetchMatchingRulesDone. FetchMatchingRules should not be called if a
// fetch to matching rules is already in progress.
- void FetchMatchingRules() const;
+ virtual void FetchMatchingRules() const;
// Called by Java when new matching rules have been fetched.
// |app_package_name| is the package name of the app that should be matched.
@@ -93,6 +93,10 @@ class ExternalDataUseObserverBridge {
jobject obj,
bool is_control_app_installed) const;
+ // Called by DataUseMatcher to notify |external_data_use_observer_| if it
+ // should register as a data use observer.
+ virtual void ShouldRegisterAsDataUseObserver(bool should_register) const;
+
private:
// Java listener that provides regular expressions to |this|. Data use
// reports are submitted to |j_external_data_use_observer_|.

Powered by Google App Engine
This is Rietveld 408576698