Remove one thread hop while fetching matching rules

chrome/browser/android/data_usage/external_data_use_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
 #define CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 64 matching lines @@
 
   // Returns the pointer to the DataUseTabModel object owned by |this|. The
   // caller does not owns the returned pointer.
   DataUseTabModel* GetDataUseTabModel() const;
 
   // Called by ExternalDataUseObserverBridge::OnReportDataUseDone when a data
   // use report has been submitted. |success| is true if the request was
   // successfully submitted to the external data use observer by Java.
   void OnReportDataUseDone(bool success);
 
-  // Called by DataUseMatcher. |should_register| is true if |this| should
-  // register as a data use observer.
+  // Called by ExternalDataUseObserverBridge. |should_register| is true if
+  // |this| should register as a data use observer.
   void ShouldRegisterAsDataUseObserver(bool should_register);
 
   // Fetches the matching rules asynchronously.
   void FetchMatchingRules();
 
   base::WeakPtr<ExternalDataUseObserver> GetWeakPtr();
 
  private:
   friend class DataUseTabModelTest;
+  friend class DataUseUITabModelTest;
   friend class ExternalDataUseObserverTest;
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferDataUseReports);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferSize);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, DataUseReportTimedOut);
 #if defined(OS_ANDROID)
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest,
                            DataUseReportingOnApplicationStatusChange);
 #endif
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, HashFunction);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest,
@@ skipping 105 matching lines @@
 
 #if defined(OS_ANDROID)
   // Called whenever the application transitions from foreground to background
   // or vice versa.
   void OnApplicationStateChange(base::android::ApplicationState new_state);
 #endif
 
   // Aggregator that sends data use observations to |this|.
   data_usage::DataUseAggregator* data_use_aggregator_;
 
+  // |external_data_use_observer_bridge_| is owned by |this|, and interacts with
+  // the Java code. It is created on IO thread but afterwards, should only be
+  // accessed on UI thread.
+  ExternalDataUseObserverBridge* external_data_use_observer_bridge_;
+
   // Maintains tab sessions and is owned by |this|. It is created on IO thread
   // but afterwards, should only be accessed on UI thread.
   DataUseTabModel* data_use_tab_model_;
 
   // Time when the currently pending data use report was submitted.
   // |last_data_report_submitted_ticks_| is null if no data use report is
   // currently pending.
   base::TimeTicks last_data_report_submitted_ticks_;
 
   // |pending_report_bytes_| is the total byte count in the data use report that
   // is currently pending.
   int64_t pending_report_bytes_;
 
   // Buffered data reports that need to be submitted to the
   // |external_data_use_observer_bridge_|.
   DataUseReports buffered_data_reports_;
 
   // |ui_task_runner_| is used to call methods on UI thread.
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
   // Time when the data use reports were last received from DataUseAggregator.
   base::Time previous_report_time_;
 
   // Time when the matching rules were last fetched.
   base::TimeTicks last_matching_rules_fetch_time_;
 
-  // |external_data_use_observer_bridge_| is owned by |this|, and interacts with
-  // the Java code. It is created on IO thread but afterwards, should only be
-  // accessed on UI thread.
-  ExternalDataUseObserverBridge* external_data_use_observer_bridge_;
-
   // Total number of bytes transmitted or received across all the buffered
   // reports.
   int64_t total_bytes_buffered_;
 
   // Duration after which matching rules are periodically fetched.
   const base::TimeDelta fetch_matching_rules_duration_;
 
   // Minimum number of bytes that should be buffered before a data use report is
   // submitted.
   const int64_t data_use_report_min_bytes_;
@@ skipping 16 matching lines @@
   base::WeakPtrFactory<ExternalDataUseObserver> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExternalDataUseObserver);
 };
 
 }  // namespace android
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_