Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/about_flags.cc

Issue 1772233003: Flag for Background Loading of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change to use the Feature object to implement the flags. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index a2055020cbdbadf625cd4594368df4acbd9a704d..2f1ef573bf29f859047db69d0440a801f16eecbc 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1621,6 +1621,10 @@ const FeatureEntry kFeatureEntries[] = {
{"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME,
IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)},
+ {"offline-pages-backgorund_loading_mode",
jianli 2016/03/12 00:08:30 nit: replace "_" with '-". Also you can drop "mode
Pete Williamson 2016/03/12 00:48:29 Done.
+ IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
+ IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
+ FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)},
#endif // defined(OS_ANDROID)
{"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME,
IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698