chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java - Issue 1772233003: Flag for Background Loading of Offline Pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 1772233003: Flag for Background Loading of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Put @VisibleForTesting in the right place. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('k') | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

index 78f819e1da22a2880a8a8e7de9a43086bc7c1e1f..dcdb1dda1535a07cab1b007b46577a94597c57b7 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

@@ -258,6 +258,14 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi

mOfflinePageBridge.getOfflineUrlForOnlineUrl(offlinePage.getUrl()));

}

+ @CommandLineFlags.Add("disable-features=offline-pages-background-loading")

+ @SmallTest

+ public void testBackgroundLoadSwitch() throws Exception {

+ // We should be able to call the C++ is enabled function from the Java side.

+ assertFalse("If background loading is off, we should see the feature disabled",

+ OfflinePageBridge.isBackgroundLoadingEnabled());

+ }

private void savePage(final int expectedResult, final String expectedUrl)

throws InterruptedException {

final Semaphore semaphore = new Semaphore(0);