Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3249)

Unified Diff: chrome/browser/about_flags.cc

Issue 1772233003: Flag for Background Loading of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 6ec41ea83f5d8f4fe215c2ceac46b19f682c4455..34515cf2160b2aa1c9f1de05feef8993a0e235cf 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -528,6 +528,14 @@ const FeatureEntry::Choice kEnableOfflinePagesChoices[] = {
""},
};
+const FeatureEntry::Choice kEnableOfflinePagesBackgroundLoadingChoices[] = {
+ {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
+ {IDS_FLAGS_ENABLE_OFFLINE_PAGES_BACKGROUND_LOADING,
+ switches::kEnableOfflinePagesAsBookmarks, ""},
fgorski 2016/03/09 18:00:04 ??
Pete Williamson 2016/03/09 20:36:32 fixed the copy-paste bug with the switch name
+ {IDS_FLAGS_DISABLE_OFFLINE_PAGES_BACKGROUND_LOADING,
+ switches::kEnableOfflinePagesAsSavedPages, ""},
fgorski 2016/03/09 18:00:04 ??
Pete Williamson 2016/03/09 20:36:32 Done.
+};
+
const FeatureEntry::Choice kHerbPrototypeChoices[] = {
{IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
{IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
@@ -1618,6 +1626,10 @@ const FeatureEntry kFeatureEntries[] = {
{"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME,
IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)},
+ {"offline-pages-backgorund_loading_mode",
+ IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
+ IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
+ MULTI_VALUE_TYPE(kEnableOfflinePagesBackgroundLoadingChoices)},
#endif // defined(OS_ANDROID)
{"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME,
IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll,

Powered by Google App Engine
This is Rietveld 408576698