Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1772233003: Flag for Background Loading of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust line spacing Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 const FeatureEntry::Choice kEnableOfflinePagesChoices[] = { 524 const FeatureEntry::Choice kEnableOfflinePagesChoices[] = {
525 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 525 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
526 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS, 526 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS,
527 switches::kEnableOfflinePagesAsBookmarks, ""}, 527 switches::kEnableOfflinePagesAsBookmarks, ""},
528 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES, 528 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES,
529 switches::kEnableOfflinePagesAsSavedPages, ""}, 529 switches::kEnableOfflinePagesAsSavedPages, ""},
530 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages, 530 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages,
531 ""}, 531 ""},
532 }; 532 };
533 533
534 const FeatureEntry::Choice kEnableOfflinePagesBackgroundLoadingChoices[] = {
535 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
536 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_BACKGROUND_LOADING,
537 switches::kEnableOfflinePagesBackgroundLoading, ""},
538 {IDS_FLAGS_DISABLE_OFFLINE_PAGES_BACKGROUND_LOADING,
539 switches::kDisableOfflinePagesBackgroundLoading, ""},
540 };
541
534 const FeatureEntry::Choice kHerbPrototypeChoices[] = { 542 const FeatureEntry::Choice kHerbPrototypeChoices[] = {
535 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 543 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
536 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 544 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
537 switches::kTabManagementExperimentTypeDisabled, ""}, 545 switches::kTabManagementExperimentTypeDisabled, ""},
538 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ANISE, 546 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ANISE,
539 switches::kTabManagementExperimentTypeAnise, ""}, 547 switches::kTabManagementExperimentTypeAnise, ""},
540 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL, 548 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL,
541 switches::kTabManagementExperimentTypeBasil, ""}, 549 switches::kTabManagementExperimentTypeBasil, ""},
542 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE, 550 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE,
543 switches::kTabManagementExperimentTypeChive, ""}, 551 switches::kTabManagementExperimentTypeChive, ""},
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
1614 #endif // defined(TOOLKIT_VIEWS) 1622 #endif // defined(TOOLKIT_VIEWS)
1615 #if defined(OS_ANDROID) 1623 #if defined(OS_ANDROID)
1616 {"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME, 1624 {"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME,
1617 IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid, 1625 IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid,
1618 MULTI_VALUE_TYPE(kProgressBarAnimationChoices)}, 1626 MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
1619 #endif // defined(OS_ANDROID) 1627 #endif // defined(OS_ANDROID)
1620 #if defined(OS_ANDROID) 1628 #if defined(OS_ANDROID)
1621 {"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME, 1629 {"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME,
1622 IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid, 1630 IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
1623 MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)}, 1631 MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)},
1632 {"offline-pages-backgorund_loading_mode",
1633 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
1634 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
1635 MULTI_VALUE_TYPE(kEnableOfflinePagesBackgroundLoadingChoices)},
1624 #endif // defined(OS_ANDROID) 1636 #endif // defined(OS_ANDROID)
1625 {"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME, 1637 {"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME,
1626 IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll, 1638 IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll,
1627 // NOTE: if we want to add additional experiment entries for other 1639 // NOTE: if we want to add additional experiment entries for other
1628 // features controlled by kBlinkSettings, we'll need to add logic to 1640 // features controlled by kBlinkSettings, we'll need to add logic to
1629 // merge the flag values. 1641 // merge the flag values.
1630 SINGLE_VALUE_TYPE_AND_VALUE(switches::kBlinkSettings, 1642 SINGLE_VALUE_TYPE_AND_VALUE(switches::kBlinkSettings,
1631 "lowPriorityIframes=true")}, 1643 "lowPriorityIframes=true")},
1632 #if defined(OS_ANDROID) 1644 #if defined(OS_ANDROID)
1633 {"enable-ntp-popular-sites", IDS_FLAGS_NTP_POPULAR_SITES_NAME, 1645 {"enable-ntp-popular-sites", IDS_FLAGS_NTP_POPULAR_SITES_NAME,
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
2019 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2031 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2020 2032
2021 const FeatureEntry* GetFeatureEntries(size_t* count) { 2033 const FeatureEntry* GetFeatureEntries(size_t* count) {
2022 *count = arraysize(kFeatureEntries); 2034 *count = arraysize(kFeatureEntries);
2023 return kFeatureEntries; 2035 return kFeatureEntries;
2024 } 2036 }
2025 2037
2026 } // namespace testing 2038 } // namespace testing
2027 2039
2028 } // namespace about_flags 2040 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698