Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1772233003: Flag for Background Loading of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put @VisibleForTesting in the right place. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1583 matching lines...) Expand 10 before | Expand all | Expand 10 after
1594 FEATURE_VALUE_TYPE(features::kSimplifiedFullscreenUI)}, 1594 FEATURE_VALUE_TYPE(features::kSimplifiedFullscreenUI)},
1595 #if defined(OS_ANDROID) 1595 #if defined(OS_ANDROID)
1596 {"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME, 1596 {"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME,
1597 IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid, 1597 IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid,
1598 MULTI_VALUE_TYPE(kProgressBarAnimationChoices)}, 1598 MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
1599 #endif // defined(OS_ANDROID) 1599 #endif // defined(OS_ANDROID)
1600 #if defined(OS_ANDROID) 1600 #if defined(OS_ANDROID)
1601 {"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME, 1601 {"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME,
1602 IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid, 1602 IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
1603 MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)}, 1603 MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)},
1604 {"offline-pages-background-loading",
1605 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
1606 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
1607 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)},
1604 #endif // defined(OS_ANDROID) 1608 #endif // defined(OS_ANDROID)
1605 {"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME, 1609 {"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME,
1606 IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll, 1610 IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll,
1607 // NOTE: if we want to add additional experiment entries for other 1611 // NOTE: if we want to add additional experiment entries for other
1608 // features controlled by kBlinkSettings, we'll need to add logic to 1612 // features controlled by kBlinkSettings, we'll need to add logic to
1609 // merge the flag values. 1613 // merge the flag values.
1610 SINGLE_VALUE_TYPE_AND_VALUE(switches::kBlinkSettings, 1614 SINGLE_VALUE_TYPE_AND_VALUE(switches::kBlinkSettings,
1611 "lowPriorityIframes=true")}, 1615 "lowPriorityIframes=true")},
1612 #if defined(OS_ANDROID) 1616 #if defined(OS_ANDROID)
1613 {"enable-ntp-popular-sites", IDS_FLAGS_NTP_POPULAR_SITES_NAME, 1617 {"enable-ntp-popular-sites", IDS_FLAGS_NTP_POPULAR_SITES_NAME,
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
2002 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2006 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2003 2007
2004 const FeatureEntry* GetFeatureEntries(size_t* count) { 2008 const FeatureEntry* GetFeatureEntries(size_t* count) {
2005 *count = arraysize(kFeatureEntries); 2009 *count = arraysize(kFeatureEntries);
2006 return kFeatureEntries; 2010 return kFeatureEntries;
2007 } 2011 }
2008 2012
2009 } // namespace testing 2013 } // namespace testing
2010 2014
2011 } // namespace about_flags 2015 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698