Flag for Background Loading of Offline Pages.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 510 matching lines @@
 const FeatureEntry::Choice kEnableOfflinePagesChoices[] = {
     {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
     {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS,
      switches::kEnableOfflinePagesAsBookmarks, ""},
     {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES,
      switches::kEnableOfflinePagesAsSavedPages, ""},
     {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages,
      ""},
 };
 
+const FeatureEntry::Choice kEnableOfflinePagesBackgroundLoadingChoices[] = {
+    {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
+    {IDS_FLAGS_ENABLE_OFFLINE_PAGES_BACKGROUND_LOADING,
+     switches::kEnableOfflinePagesAsBookmarks, ""},

[fgorski, 2016/03/09 18:00:04]

??

[Pete Williamson, 2016/03/09 20:36:32]

fixed the copy-paste bug with the switch name

+    {IDS_FLAGS_DISABLE_OFFLINE_PAGES_BACKGROUND_LOADING,
+     switches::kEnableOfflinePagesAsSavedPages, ""},

[fgorski, 2016/03/09 18:00:04]

??

[Pete Williamson, 2016/03/09 20:36:32]

Done.

+};
+
 const FeatureEntry::Choice kHerbPrototypeChoices[] = {
     {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
     {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
      switches::kTabManagementExperimentTypeDisabled, ""},
     {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ANISE,
      switches::kTabManagementExperimentTypeAnise, ""},
     {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL,
      switches::kTabManagementExperimentTypeBasil, ""},
     {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE,
      switches::kTabManagementExperimentTypeChive, ""},
@@ skipping 1070 matching lines @@
 #endif  // defined(TOOLKIT_VIEWS)
 #if defined(OS_ANDROID)
     {"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME,
      IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid,
      MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
 #endif  // defined(OS_ANDROID)
 #if defined(OS_ANDROID)
     {"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME,
      IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
      MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)},
+    {"offline-pages-backgorund_loading_mode",
+     IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
+     IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
+     MULTI_VALUE_TYPE(kEnableOfflinePagesBackgroundLoadingChoices)},
 #endif  // defined(OS_ANDROID)
     {"low-priority-iframes", IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_NAME,
      IDS_FLAGS_LOW_PRIORITY_IFRAMES_UI_DESCRIPTION, kOsAll,
      // NOTE: if we want to add additional experiment entries for other
      // features controlled by kBlinkSettings, we'll need to add logic to
      // merge the flag values.
      SINGLE_VALUE_TYPE_AND_VALUE(switches::kBlinkSettings,
                                  "lowPriorityIframes=true")},
 #if defined(OS_ANDROID)
     {"enable-ntp-popular-sites", IDS_FLAGS_NTP_POPULAR_SITES_NAME,
@@ skipping 370 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags