Chromium Code Reviews
DescriptionRevert of TextIteratorAlgorithm should not force layout update in constructor. (patchset #1 id:1 of https://codereview.chromium.org/1769683002/ )
Reason for revert:
Caused several fun crashes and security bugs.
Original issue's description:
> TextIteratorAlgorithm should not force layout update in constructor.
>
> Asking to update layout should not be done at this level.
> Updating layout is part of the document/view lifecycle
> and should be coordinated at a higher level
> than an iterator constructor.
>
> Thus, move calling Document::updateLayoutIgnorePendingStylesheets up
> to the callsites of the TextIterator constructor.
> These callsites should be audited and moved up
> even farther up the call stack.
>
> This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.
>
> BUG=590295
> R=esprehn
>
> Committed: https://crrev.com/3576860f06d835f699521bccbb134b65d7326dca
> Cr-Commit-Position: refs/heads/master@{#379408}
TBR=esprehn@chromium.org,ojan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=590295
Committed: https://crrev.com/a6b0d964fc925995fb6cfed0ede72736137bca48
Cr-Commit-Position: refs/heads/master@{#379730}
Patch Set 1 #Messages
Total messages: 8 (1 generated)
|