Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1772223002: Revert of TextIteratorAlgorithm should not force layout update in constructor. (Closed)

Created:
4 years, 9 months ago by dglazkov
Modified:
4 years, 9 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, groby+blinkspell_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of TextIteratorAlgorithm should not force layout update in constructor. (patchset #1 id:1 of https://codereview.chromium.org/1769683002/ ) Reason for revert: Caused several fun crashes and security bugs. Original issue's description: > TextIteratorAlgorithm should not force layout update in constructor. > > Asking to update layout should not be done at this level. > Updating layout is part of the document/view lifecycle > and should be coordinated at a higher level > than an iterator constructor. > > Thus, move calling Document::updateLayoutIgnorePendingStylesheets up > to the callsites of the TextIterator constructor. > These callsites should be audited and moved up > even farther up the call stack. > > This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74. > > BUG=590295 > R=esprehn > > Committed: https://crrev.com/3576860f06d835f699521bccbb134b65d7326dca > Cr-Commit-Position: refs/heads/master@{#379408} TBR=esprehn@chromium.org,ojan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590295 Committed: https://crrev.com/a6b0d964fc925995fb6cfed0ede72736137bca48 Cr-Commit-Position: refs/heads/master@{#379730}

Patch Set 1 #

Messages

Total messages: 8 (1 generated)
dglazkov
Created Revert of TextIteratorAlgorithm should not force layout update in constructor.
4 years, 9 months ago (2016-03-08 02:32:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772223002/1
4 years, 9 months ago (2016-03-08 02:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772223002/1
4 years, 9 months ago (2016-03-08 03:01:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772223002/1
4 years, 9 months ago (2016-03-08 03:31:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772223002/1
4 years, 9 months ago (2016-03-08 04:01:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 04:11:41 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 04:12:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6b0d964fc925995fb6cfed0ede72736137bca48
Cr-Commit-Position: refs/heads/master@{#379730}

Powered by Google App Engine
This is Rietveld 408576698