blimp/docs/build.md - Issue 1772213002: Create doc on build arg best practices for Blimp.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/docs/build.md

Issue 1772213002: Create doc on build arg best practices for Blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address doc review recommendations pending larger structure discussion. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Using GN	1 # Using GN

2 Blimp only supports building using [GN](../../tools/gn/README.md). A quick	2 Blimp only supports building using [GN](../../tools/gn/README.md). A quick

3 overview over how to use GN can be found in the GN	3 overview over how to use GN can be found in the GN

4 [quick start guide](../../tools/gn/docs/quick_start.md).	4 [quick start guide](../../tools/gn/docs/quick_start.md).

	5 If you want to add new arguments, see the

	6 [build arguments guide](args.md).
	Dirk Pranke 2016/03/09 01:28:45 I would try to distinguish between creating an ent I would try to distinguish between creating an entirely new flag (which we should be trying to avoid, but if we do need to do it, try to document it generically in the GN docs) and needing to set a particular flag to a particular value (which we do need), in which case you need to update the build template files in that case ... Jess 2016/03/09 19:14:27 Done. Show quoted text On 2016/03/09 01:28:45, Dirk Pranke wrote: > I would try to distinguish between creating an entirely new flag (which we > should be trying to avoid, but if we do need to do it, try to document it > generically in the GN docs) and needing to set a particular flag to a particular > value (which we do need), in which case you need to update the build template > files in that case ... Done.
5	7

6 There are three different build configurations depending on what you want to	8 There are two different build configurations depending on what you want to

7 build:	9 build:

8	10

9 ## Android client	11 ## Android client

10	12

11 Create an out-directory and set the GN args:	13 Create an out-directory and set the GN args:

12	14

13 ```bash	15 ```bash

14 mkdir -p out-android/Debug	16 mkdir -p out-android/Debug

15 echo "import(\"//build/args/blimp_client.gn\")" > out-android/Debug/args.gn	17 echo "import(\"//build/args/blimp_client.gn\")" > out-android/Debug/args.gn

16 gn gen out-android/Debug	18 gn gen out-android/Debug

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49	51

50 ```bash	52 ```bash

51 ninja -C out-linux/Debug blimp	53 ninja -C out-linux/Debug blimp

52 ```	54 ```

53	55

54 To add your own build preferences	56 To add your own build preferences

55	57

56 ```bash	58 ```bash

57 gn args out-android/Debug	59 gn args out-android/Debug

58 ```	60 ```

OLD	NEW

« blimp/docs/args.md ('K') | « blimp/docs/args.md ('k') | no next file » | no next file with comments »