Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1772173002: [Findit] Adding swarming task metadata query page (Closed)

Created:
4 years, 9 months ago by lijeffrey
Modified:
4 years, 9 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Adding swarming task metadata query page BUG=592658 Committed: https://chromium.googlesource.com/infra/infra/+/777b81d91ac0d5415cc7fa7d78fb72067d923291

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Total comments: 2

Patch Set 3 : Addressing comments #

Patch Set 4 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -0 lines) Patch
A appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py View 1 2 3 1 chunk +356 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
lijeffrey
Hey guys, This script (based on the one for try-jobs) pulls metadata for swarming tasks ...
4 years, 9 months ago (2016-03-08 00:55:44 UTC) #3
chanli
lgtm with a nit https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py (right): https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py#newcode239 appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:239: for step, swarming_task_data_list in steps.iteritems(): ...
4 years, 9 months ago (2016-03-08 23:31:39 UTC) #4
lijeffrey
Comments addressed, ptal :) https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py (right): https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py#newcode239 appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:239: for step, swarming_task_data_list in steps.iteritems(): ...
4 years, 9 months ago (2016-03-09 18:36:53 UTC) #5
stgao
https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py (right): https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py#newcode328 appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:328: categorized_data_dict = _CategorizeSwarmingTaskData(data_list) We might want to ignore pending ...
4 years, 9 months ago (2016-03-09 19:01:36 UTC) #6
lijeffrey
Comments addressed, ptal https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py (right): https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py#newcode328 appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:328: categorized_data_dict = _CategorizeSwarmingTaskData(data_list) On 2016/03/09 19:01:36, ...
4 years, 9 months ago (2016-03-09 23:16:59 UTC) #7
stgao
lgtm
4 years, 9 months ago (2016-03-09 23:45:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772173002/60001
4 years, 9 months ago (2016-03-10 00:35:14 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 00:40:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/777b81d91ac0d5415cc7fa7d78fb7...

Powered by Google App Engine
This is Rietveld 408576698