[Findit] Adding swarming task metadata query page

[Findit] Adding swarming task metadata query page

BUG=592658
Committed: https://chromium.googlesource.com/infra/infra/+/777b81d91ac0d5415cc7fa7d78fb72067d923291

[lijeffrey, 2016-03-08 00:54:45]

Description was changed from

==========
[Findit] Adding swarming task metadata query page

BUG=
==========

to

==========
[Findit] Adding swarming task metadata query page

BUG=592658
==========

[lijeffrey, 2016-03-08 00:54:45]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-03-08 00:55:44]

Hey guys,

This script (based on the one for try-jobs) pulls metadata for swarming tasks
and displays them in an html page. The dates are hard-coded, but should be
easily modified locally when running the script. PTAL when you have the chance.

Thanks,
Jeff

[chanli, 2016-03-08 23:31:39]

lgtm with a nit

https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py
(right):

https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:239:
for step, swarming_task_data_list in steps.iteritems():
nit: Since the layers are fixed, maybe you can use something like
report = defaultdict(lambda: defaultdict(lambda: defaultdict(dict)))?

[lijeffrey, 2016-03-09 18:36:53]

Comments addressed, ptal :)

https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py
(right):

https://codereview.chromium.org/1772173002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:239:
for step, swarming_task_data_list in steps.iteritems():
On 2016/03/08 23:31:39, chanli wrote:
> nit: Since the layers are fixed, maybe you can use something like
> report = defaultdict(lambda: defaultdict(lambda: defaultdict(dict)))?

Done.

[stgao, 2016-03-09 19:01:36]

https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_s...
File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py
(right):

https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_s...
appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:328:
categorized_data_dict = _CategorizeSwarmingTaskData(data_list)
We might want to ignore pending & running tasks, and only account for completed
tasks.

Should we also have an error rate report for all completed tasks?

[lijeffrey, 2016-03-09 23:16:59]

Comments addressed, ptal

https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_s...
File appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py
(right):

https://codereview.chromium.org/1772173002/diff/20001/appengine/findit/util_s...
appengine/findit/util_scripts/remote_queries/swarming_task_data_query.py:328:
categorized_data_dict = _CategorizeSwarmingTaskData(data_list)
On 2016/03/09 19:01:36, stgao wrote:
> We might want to ignore pending & running tasks, and only account for
completed
> tasks.
> 
> Should we also have an error rate report for all completed tasks?

Done.

[stgao, 2016-03-09 23:45:47]

lgtm

[lijeffrey, 2016-03-10 00:35:05]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-03-10 00:35:05]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org
Link to the patchset: https://codereview.chromium.org/1772173002/#ps60001
(title: "Cleanup")

[commit-bot: I haz the power, 2016-03-10 00:35:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772173002/60001

[commit-bot: I haz the power, 2016-03-10 00:40:12]

Description was changed from

==========
[Findit] Adding swarming task metadata query page

BUG=592658
==========

to

==========
[Findit] Adding swarming task metadata query page

BUG=592658

Committed:
https://chromium.googlesource.com/infra/infra/+/777b81d91ac0d5415cc7fa7d78fb7...
==========

[commit-bot: I haz the power, 2016-03-10 00:40:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/777b81d91ac0d5415cc7fa7d78fb7...