Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1772163003: WTF: Move TypeTraits.cpp to test-only target. (Closed)

Created:
4 years, 9 months ago by Yuta Kitamura
Modified:
4 years, 9 months ago
Reviewers:
*haraken, tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF: Move TypeTraits.cpp to test-only target. This patch renames TypeTraits.cpp to TypeTraitsTest.cpp and makes it part of wtf_unittest instead of wtf target. Additionally, its content is surrounded with anonymous namespace to indicate that the classes defined there are not exposed in WTF namespace. The file only contains static_assert assertions, so it doesn't have to be compiled into wtf. This change is a preparation of the fix for bug 592767. BUG=592767 Committed: https://crrev.com/4a08542fb0f317809a3fca5ff092cfa60c1e52ac Cr-Commit-Position: refs/heads/master@{#379800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -103 lines) Patch
D third_party/WebKit/Source/wtf/TypeTraits.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
A + third_party/WebKit/Source/wtf/TypeTraitsTest.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Yuta Kitamura
PTAL? This change is a simple cleanup.
4 years, 9 months ago (2016-03-08 09:02:03 UTC) #4
haraken
LGTM
4 years, 9 months ago (2016-03-08 09:07:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772163003/1
4 years, 9 months ago (2016-03-08 09:08:24 UTC) #7
tzik
lgtm
4 years, 9 months ago (2016-03-08 09:08:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 10:19:15 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 10:20:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a08542fb0f317809a3fca5ff092cfa60c1e52ac
Cr-Commit-Position: refs/heads/master@{#379800}

Powered by Google App Engine
This is Rietveld 408576698