Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: components/ssl_errors/error_classification_unittest.cc

Issue 1772143002: Use network time for bad clock interstitial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: estark review 3 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ssl_errors/error_classification_unittest.cc
diff --git a/components/ssl_errors/error_classification_unittest.cc b/components/ssl_errors/error_classification_unittest.cc
index 1d1d1b261d9ac1d8bb7b673fba23f18cea999695..770da986d349fe9d5ce3a0f927033a75d9d10c8f 100644
--- a/components/ssl_errors/error_classification_unittest.cc
+++ b/components/ssl_errors/error_classification_unittest.cc
@@ -6,6 +6,10 @@
#include "base/files/file_path.h"
#include "base/strings/string_split.h"
+#include "base/time/default_clock.h"
+#include "base/time/default_tick_clock.h"
+#include "components/network_time/network_time_tracker.h"
+#include "components/prefs/testing_pref_service.h"
#include "net/base/net_errors.h"
#include "net/base/test_data_directory.h"
#include "net/cert/x509_cert_types.h"
@@ -178,3 +182,77 @@ TEST(ErrorClassification, LevenshteinDistance) {
EXPECT_EQ(7u, ssl_errors::GetLevenshteinDistance("yyy", "xxxxxxx"));
EXPECT_EQ(7u, ssl_errors::GetLevenshteinDistance("xxxxxxx", "yyy"));
}
+
+TEST_F(SSLErrorClassificationTest, GetClockState) {
+ // This test aims to obtain all possible return values of
+ // |GetClockState|.
+ TestingPrefServiceSimple pref_service;
+ network_time::NetworkTimeTracker::RegisterPrefs(pref_service.registry());
+ network_time::NetworkTimeTracker network_time_tracker(
+ make_scoped_ptr(new base::DefaultClock()),
+ make_scoped_ptr(new base::DefaultTickClock()), &pref_service);
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_UNKNOWN,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ ssl_errors::SetBuildTimeForTesting(base::Time::Now() -
+ base::TimeDelta::FromDays(367));
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_FUTURE,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ ssl_errors::SetBuildTimeForTesting(base::Time::Now() +
+ base::TimeDelta::FromDays(3));
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_PAST,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ // Intentionally leave the build time alone. It should be ignored
+ // in favor of network time.
+ network_time_tracker.UpdateNetworkTime(
+ base::Time::Now() + base::TimeDelta::FromHours(1),
+ base::TimeDelta::FromSeconds(1), // resolution
+ base::TimeDelta::FromMilliseconds(250), // latency
+ base::TimeTicks::Now()); // posting time
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_PAST,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ network_time_tracker.UpdateNetworkTime(
+ base::Time::Now() - base::TimeDelta::FromHours(1),
+ base::TimeDelta::FromSeconds(1), // resolution
+ base::TimeDelta::FromMilliseconds(250), // latency
+ base::TimeTicks::Now()); // posting time
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_FUTURE,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ network_time_tracker.UpdateNetworkTime(
+ base::Time::Now(),
+ base::TimeDelta::FromSeconds(1), // resolution
+ base::TimeDelta::FromMilliseconds(250), // latency
+ base::TimeTicks::Now()); // posting time
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_OK,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ // Now clear the network time. The build time should reassert
+ // itself.
+ network_time_tracker.UpdateNetworkTime(
+ base::Time(),
+ base::TimeDelta::FromSeconds(1), // resolution
+ base::TimeDelta::FromMilliseconds(250), // latency
+ base::TimeTicks::Now()); // posting time
+ ssl_errors::SetBuildTimeForTesting(base::Time::Now() +
+ base::TimeDelta::FromDays(3));
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_PAST,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+
+ // Now set the build time to something reasonable. We should be
+ // back to the know-nothing state.
+ ssl_errors::SetBuildTimeForTesting(base::Time::Now());
+ EXPECT_EQ(
+ ssl_errors::ClockState::CLOCK_STATE_UNKNOWN,
+ ssl_errors::GetClockState(base::Time::Now(), &network_time_tracker));
+}

Powered by Google App Engine
This is Rietveld 408576698