Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1772143002: Use network time for bad clock interstitial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pass "gn check out/Default" Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/ssl_errors/error_classification_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 52a56ae69528647261eef5d481a2ba41e8e07fa1..148e6c3e6d7337164c61ae4c17d62ac30aad472d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -17788,6 +17788,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="interstitial.ssl.clockstate.build_time" enum="ClockStates">
+ <owner>mab@chromium.org</owner>
+ <summary>
+ State of the system clock, as inferred from the build timestamp, when an SSL
+ CERT_INVALID_DATE error is seen.
+ </summary>
+</histogram>
+
+<histogram name="interstitial.ssl.clockstate.network" enum="ClockStates">
+ <owner>mab@chromium.org</owner>
+ <summary>
+ State of the system clock, relative to network time, when an SSL
+ CERT_INVALID_DATE error is seen.
+ </summary>
+</histogram>
+
<histogram name="interstitial.ssl.connection_type"
enum="ResourcePrefetchPredictorNetworkType">
<owner>felt@chromium.org</owner>
@@ -60274,6 +60290,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="2" label="Read Text"/>
</enum>
+<enum name="ClockStates" type="int">
+ <int value="0"
+ label="CLOCK_STATE_UNKNOWN: accuracy of system clock is unknown"/>
+ <int value="1" label="CLOCK_STATE_OK: system clock is roughly accurate"/>
+ <int value="2" label="CLOCK_STATE_PAST: system clock is in the past"/>
+ <int value="3" label="CLOCK_STATE_FUTURE: system clock is in the future"/>
+</enum>
+
<enum name="CloudImportUserAction" type="int">
<int value="0" label="IMPORT_INITIATED"/>
</enum>
@@ -80665,8 +80689,16 @@ To add a new entry, add it with any value and run test to compute valid value.
</enum>
<enum name="SSLErrorCauses" type="int">
- <int value="0" label="CLOCK_PAST: System clock set early"/>
- <int value="1" label="CLOCK_FUTURE: System clock set late"/>
+ <int value="0" label="CLOCK_PAST: System clock set early">
+ This cause is recorded if the SSL error is CERT_DATE_INVALID and Chrome had
+ reason to believe that the system clock was behind. Methods of detecting
+ clock inaccuracy have changed over time.
+ </int>
+ <int value="1" label="CLOCK_FUTURE: System clock set late">
+ This cause is recorded if the SSL error is CERT_DATE_INVALID and Chrome had
+ reason to believe that the system clock was behind. Methods of detecting
+ clock inaccuracy have changed over time.
+ </int>
<int value="2"
label="WWW_SUBDOMAIN_MATCH: Difference between the URL and the DNS is
www">
« no previous file with comments | « components/ssl_errors/error_classification_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698