Use network time for bad clock interstitial.

components/ssl_errors/error_classification.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SSL_ERRORS_ERROR_CLASSIFICATION_H_
 #define COMPONENTS_SSL_ERRORS_ERROR_CLASSIFICATION_H_
 
 #include <string>
 #include <vector>
 
 namespace base {
 class Time;
 }
 
 class GURL;
 
 namespace net {
 class X509Certificate;
 }
 
+namespace network_time {
+class NetworkTimeTracker;
+}
+
 namespace ssl_errors {
 
 typedef std::vector<std::string> HostnameTokens;
 
 // Methods for identifying specific error causes. ------------------------------
 
 // Returns true if the system time is in the past.
-bool IsUserClockInThePast(const base::Time& time_now);
+bool IsUserClockAhead(const base::Time& time_now,

[estark, 2016/03/08 23:17:36]

My brain might not be doing logic correctly but it looks to me like the comments
on IsUserClockAhead() and IsUserClockBehind() are reversed and don't match up
with the new names? Also just curious why you decided to change the function
names. (I don't really have a preference for the old or the new.)

And, I think the comments need to be expanded with a little more detail now that
these functions are a bit more complicated. For example, "Returns true if the
system time is in the past, as indicated by network time when available or as
estimated using a heuristic based on build time, when network time is not
available." Maybe something like that?

[estark, 2016/03/08 23:17:36]

Can you name these |now_system|, like you did in the definition?

[mab, 2016/03/09 23:35:28]

I changed it to be shorter, but I've changed it back, since apparently I managed
to confuse myself with the new names.

Hopefully the comments on the new enum speak to what you are looking for.

[mab, 2016/03/09 23:35:28]

Done.

+                      const network_time::NetworkTimeTracker* network_time);
 
 // Returns true if the system time is too far in the future or the user is
 // using a version of Chrome which is more than 1 year old.
-bool IsUserClockInTheFuture(const base::Time& time_now);
+bool IsUserClockBehind(const base::Time& time_now,
+                       const network_time::NetworkTimeTracker* network_time);
 
 // Returns true if |hostname| is too broad for the scope of a wildcard
 // certificate. E.g.:
 //     a.b.example.com ~ *.example.com --> true
 //     b.example.com ~ *.example.com --> false
 bool IsSubDomainOutsideWildcard(const GURL& request_url,
                                 const net::X509Certificate& cert);
 
 // Returns true if the certificate is a shared certificate. Note - This
 // function should be used with caution (only for UMA histogram) as an
@@ skipping 17 matching lines @@
 //     www.food.example.com ~ example.com -> false
 //     mail.example.com ~ example.com -> false
 bool GetWWWSubDomainMatch(const GURL& request_url,
                           const std::vector<std::string>& dns_names,
                           std::string* www_match_host_name);
 
 // Method for recording results. -----------------------------------------------
 
 void RecordUMAStatistics(bool overridable,
                          const base::Time& current_time,
+                         const network_time::NetworkTimeTracker* network_time,
                          const GURL& request_url,
                          int cert_error,
                          const net::X509Certificate& cert);
 
 // Helper methods for classification. ------------------------------------------
 
 // Tokenize DNS names and hostnames.
 HostnameTokens Tokenize(const std::string& name);
 
 // Sets a clock for browser tests that check the build time. Used by
@@ skipping 19 matching lines @@
 // appspot.com.
 bool AnyNamesUnderName(const std::vector<HostnameTokens>& potential_children,
                        const HostnameTokens& parent);
 
 // Exposed for teshting.
 size_t GetLevenshteinDistance(const std::string& str1, const std::string& str2);
 
 }  // namespace ssl_errors
 
 #endif  // COMPONENTS_SSL_ERRORS_ERROR_CLASSIFICATION_H_