Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 177213013: clang-format: Allow .proto files to be formatted; remove warnings. (Closed)

Created:
6 years, 10 months ago by ncarter (slow)
Modified:
6 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

clang-format: Allow .proto files to be formatted (supported by an upcoming binary/script; this change is safe if you are running an older binary); remove warnings. BUG=344916 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253295

Patch Set 1 #

Patch Set 2 : More cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M clang_format.py View 1 2 chunks +2 lines, -22 lines 0 comments Download
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ncarter (slow)
iannucci: Please have a look
6 years, 10 months ago (2014-02-25 23:34:09 UTC) #1
iannucci
rslgtm. Thanks for following through on the cleanup :)
6 years, 10 months ago (2014-02-25 23:44:02 UTC) #2
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 10 months ago (2014-02-25 23:47:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/177213013/20001
6 years, 10 months ago (2014-02-25 23:55:02 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 23:57:05 UTC) #5
Message was sent while issue was closed.
Change committed as 253295

Powered by Google App Engine
This is Rietveld 408576698