Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 177213010: Move LiveNodeListBase class to its own header (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis, deepak.sa
Visibility:
Public.

Description

Move LiveNodeListBase class to its own header Move LiveNodeListBase class to its own header instead of having it in the LiveNodeList header. HTMLCollection also inherits from LiveNodeListBase and is not interested in the LiveNodeList class. There is still LiveNodeListBase code in HTMLCollection.cpp, this will be moved in a follow-up patch. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -165 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 chunk +2 lines, -94 lines 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
A + Source/core/dom/LiveNodeListBase.h View 3 chunks +4 lines, -35 lines 0 comments Download
A + Source/core/dom/LiveNodeListBase.cpp View 3 chunks +2 lines, -12 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
This is the easy part. The tougher one will be extracting the LiveNodeListBase code from ...
6 years, 10 months ago (2014-02-25 16:37:48 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-02-25 18:27:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/177213010/1
6 years, 10 months ago (2014-02-25 18:29:59 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 20:20:15 UTC) #4
Message was sent while issue was closed.
Change committed as 167821

Powered by Google App Engine
This is Rietveld 408576698