Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 177203002: Allocation tracker: add separate entry for allocations via V8 API (Closed)

Created:
6 years, 10 months ago by yurys
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allocation tracker: add separate entry for allocations via V8 API When object is creating via native V8 API calls JS callstack is empty and the allocation is indistinguishable from say compiler allocations. This change adds a separate entry for such allocations. Since FunctionInfo not necessarily corresponds to a heap object they are now referred to using their index in the list of all FunctionInfos. BUG=chromium:277984 LOG=N R=loislo@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19718

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverted v8globals.h changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -68 lines) Patch
M src/allocation-tracker.h View 6 chunks +17 lines, -11 lines 0 comments Download
M src/allocation-tracker.cc View 10 chunks +55 lines, -43 lines 0 comments Download
M src/heap-snapshot-generator.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 10 months ago (2014-02-24 07:36:07 UTC) #1
loislo
lgtm with nits https://codereview.chromium.org/177203002/diff/1/src/v8globals.h File src/v8globals.h (right): https://codereview.chromium.org/177203002/diff/1/src/v8globals.h#newcode370 src/v8globals.h:370: LAST_STATE_TAG = IDLE unnecessary change
6 years, 10 months ago (2014-02-24 07:56:42 UTC) #2
yurys
https://codereview.chromium.org/177203002/diff/1/src/v8globals.h File src/v8globals.h (right): https://codereview.chromium.org/177203002/diff/1/src/v8globals.h#newcode370 src/v8globals.h:370: LAST_STATE_TAG = IDLE On 2014/02/24 07:56:42, loislo wrote: > ...
6 years, 10 months ago (2014-02-24 07:57:10 UTC) #3
yurys
@mstarzinger: please do OWNERS review
6 years, 10 months ago (2014-02-24 07:58:31 UTC) #4
Michael Starzinger
LGTM (rubber-stamped).
6 years, 10 months ago (2014-02-24 09:17:00 UTC) #5
yurys
6 years, 9 months ago (2014-03-07 11:32:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r19718 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698