Lazy init batch unique ID

Lazy init batch unique ID

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772023003

Committed: https://skia.googlesource.com/skia/+/08e65e718a3464a594e6dfca0351dfed19ac2445

[joshua.litt, 2016-03-08 15:57:09]

Description was changed from

==========
Lazy init batch unique ID

BUG=skia:
==========

to

==========
Lazy init batch unique ID

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-08 15:58:04]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2016-03-08 15:58:08]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-03-08 15:58:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772023003/1

[commit-bot: I haz the power, 2016-03-08 15:58:11]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-03-08 21:58 UTC

[bsalomon, 2016-03-08 16:38:24]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-03-08 16:38:35]

lgtm w/ suggestion.

https://codereview.chromium.org/1772023003/diff/1/src/gpu/batches/GrBatch.h
File src/gpu/batches/GrBatch.h (right):

https://codereview.chromium.org/1772023003/diff/1/src/gpu/batches/GrBatch.h#n...
src/gpu/batches/GrBatch.h:98: uint32_t uniqueID() const {
Maybe a comment that we lazily initialize because we don't typically use the
uniqueID() other than for audit trail?

[joshualitt, 2016-03-08 17:20:19]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-03-08 17:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1772023003/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-03-08 17:20:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772023003/20001

[commit-bot: I haz the power, 2016-03-08 17:31:18]

Description was changed from

==========
Lazy init batch unique ID

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Lazy init batch unique ID

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/08e65e718a3464a594e6dfca0351dfed19ac2445
==========

[commit-bot: I haz the power, 2016-03-08 17:31:18]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08e65e718a3464a594e6dfca0351dfed19ac2445