Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1771963002: Make sure images loaded from MD resource packs contain all reps (Mac). (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure images loaded from MD resource packs contain all reps (Mac). A bug in GetNativeImageNamed() causes an early out when collecting image representations from MD packs. The result is NSImages containing just the 1x representation. BUG=592161 Committed: https://crrev.com/945e2bc8771685c37cfcb0fa6b855d2afefc05ed Cr-Commit-Position: refs/heads/master@{#379632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M ui/base/resource/resource_bundle_mac.mm View 1 chunk +28 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
shrike
PTAL
4 years, 9 months ago (2016-03-07 19:52:49 UTC) #3
Avi (use Gerrit)
lgtm; soon we get to switch to MD and pull out all of this mess... ...
4 years, 9 months ago (2016-03-07 20:03:40 UTC) #4
shrike
On 2016/03/07 20:03:40, Avi wrote: > lgtm; soon we get to switch to MD and ...
4 years, 9 months ago (2016-03-07 20:04:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771963002/1
4 years, 9 months ago (2016-03-07 20:04:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 20:50:55 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 20:52:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/945e2bc8771685c37cfcb0fa6b855d2afefc05ed
Cr-Commit-Position: refs/heads/master@{#379632}

Powered by Google App Engine
This is Rietveld 408576698