Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1771933002: Revert of Monitor the system native frame color on Win 10. (Closed)

Created:
4 years, 9 months ago by Will Harris
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Monitor the system native frame color on Win 10. (patchset #4 id:60001 of https://codereview.chromium.org/1744483002/ ) Reason for revert: This breaks the win10 bot. see bug 592676 Original issue's description: > Monitor the system native frame color on Win 10. > > GetColor(COLOR_FRAME...) will now report the actual in-use color for Win 10 > native frames. This is not used yet, but will be useful for: > (a) Dynamically choosing the right incognito icon color > (b) Dynamically choosing the right COLOR_TOOLBAR_TOP_SEPARATOR > (c) Eventually, converting Win 10 to custom-drawing the frame but still > respecting the user's color choice > > BUG=505013, 585470 > TEST=none > > Committed: https://crrev.com/9fcf69e0bc440b16661c39c4b9f13182f0430725 > Cr-Commit-Position: refs/heads/master@{#378989} TBR=estade@chromium.org,bsep@chromium.org,pkasting@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=505013, 585470, 592676 Committed: https://crrev.com/5855bedc3af9746d0a68471f182dcc99bbfa3299 Cr-Commit-Position: refs/heads/master@{#379611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -262 lines) Patch
M chrome/browser/themes/theme_service.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 4 chunks +145 lines, -139 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 2 chunks +2 lines, -6 lines 0 comments Download
D chrome/browser/themes/theme_service_win.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/themes/theme_service_win.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Will Harris
Created Revert of Monitor the system native frame color on Win 10.
4 years, 9 months ago (2016-03-07 18:46:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771933002/1
4 years, 9 months ago (2016-03-07 18:47:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771933002/1
4 years, 9 months ago (2016-03-07 19:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771933002/1
4 years, 9 months ago (2016-03-07 19:31:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 19:38:19 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 19:39:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5855bedc3af9746d0a68471f182dcc99bbfa3299
Cr-Commit-Position: refs/heads/master@{#379611}

Powered by Google App Engine
This is Rietveld 408576698