Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1771893002: Update status of cpsir tests in checked mode: skipping for now, since more than (Closed)

Created:
4 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 9 months ago
Reviewers:
Bill Hesse, sra1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status of cpsir tests in checked mode: skipping for now, since more than 75% fail for one reason, once we fix that we can triage in more detail. Committed: https://github.com/dart-lang/sdk/commit/385f3350c504a23fc46e09c206b6d6444448f620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +3 lines, -0 lines 0 comments Download
M samples/samples.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-07 17:47:55 UTC) #2
Siggi Cherem (dart-lang)
tbr
4 years, 9 months ago (2016-03-07 18:20:19 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 385f3350c504a23fc46e09c206b6d6444448f620 (presubmit successful).
4 years, 9 months ago (2016-03-07 18:20:46 UTC) #5
Bill Hesse
4 years, 9 months ago (2016-03-07 19:52:24 UTC) #6
Message was sent while issue was closed. 
lgtm

LGTM.  It would have been really good to have an issue filed, and the issue
number on each of these status lines.  I would file an issue now, and have a
link to this CL, so we can find all these lines again when it is fixed.

Powered by Google App Engine
This is Rietveld 408576698