Issue 1771863003: Removed whitelisted failures now fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1771863003: Removed whitelisted failures now fixed (Closed)

Created:
4 years, 9 months ago by terry

Modified:
4 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Removed whitelisted failures now fixed TBR=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/b1faa37d2a09c4605ab0f1a894083eeabe8ff9e3

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	tests/compiler/dart2js/analyze_api_test.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

terry

Committed patchset #1 (id:1) manually as b1faa37d2a09c4605ab0f1a894083eeabe8ff9e3 (presubmit successful).

4 years, 9 months ago (2016-03-07 17:39:57 UTC) #2

Bill Hesse

4 years, 9 months ago (2016-03-07 20:23:59 UTC) #3

Message was sent while issue was closed.

These failures were replaced by differently worded, but similar failures, in the
build log I gave a link to, so they needed to be replaced by them, or the
similar failures also fixed.  This should have shown up when running the test
locally.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages