Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1771863002: Corrects hot-tracked state when space or enter is pressed in a menu (Closed)

Created:
4 years, 9 months ago by varkha
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Corrects hot-tracked state when space or enter is pressed in a menu BUG=592356 Committed: https://crrev.com/061dd4d14b4941fccce1028d79111ee5d322766e Cr-Commit-Position: refs/heads/master@{#379598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/views/controls/menu/menu_controller.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
varkha
sky@, can you please take a look?
4 years, 9 months ago (2016-03-07 17:01:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771863002/1
4 years, 9 months ago (2016-03-07 17:01:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 17:45:10 UTC) #6
sky
LGTM
4 years, 9 months ago (2016-03-07 18:46:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771863002/1
4 years, 9 months ago (2016-03-07 18:56:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 19:04:06 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 19:07:44 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/061dd4d14b4941fccce1028d79111ee5d322766e
Cr-Commit-Position: refs/heads/master@{#379598}

Powered by Google App Engine
This is Rietveld 408576698