Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1771823002: Remove unnecessary setNeedsRecalcStyleInAllFrames for fonts. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary setNeedsRecalcStyleInAllFrames for fonts. Instead of walking the frame tree twice, nuking the style world the second time, do normal font cache invalidation which lets StyleEngine handle the change in StyleEngine::fontsNeedUpdate. TEST=fast/text/update-sans-serif-and-recalc-style.html Committed: https://crrev.com/e954647f67500a9fe8fff98b08e9fd9597bdc54b Cr-Commit-Position: refs/heads/master@{#379761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771823002/1
4 years, 9 months ago (2016-03-07 15:05:39 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 17:36:53 UTC) #5
rune
4 years, 9 months ago (2016-03-07 19:20:59 UTC) #7
Timothy Loh
On 2016/03/07 19:20:59, rune wrote: lgtm
4 years, 9 months ago (2016-03-08 02:24:02 UTC) #8
esprehn
lgtm
4 years, 9 months ago (2016-03-08 05:56:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771823002/1
4 years, 9 months ago (2016-03-08 05:56:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 06:04:12 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 06:06:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e954647f67500a9fe8fff98b08e9fd9597bdc54b
Cr-Commit-Position: refs/heads/master@{#379761}

Powered by Google App Engine
This is Rietveld 408576698