Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1771753002: Revert of Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage (Closed)

Created:
4 years, 9 months ago by Michael Hablich
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage (patchset #1 id:1 of https://codereview.chromium.org/1762313002/ ) Reason for revert: Breaks roll https://codereview.chromium.org/1768073002/ : https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/191035 Original issue's description: > Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage > > Now that the embedder side supports v8::kGCCallbackFlagCollectAllAvailableGarbage, > this CL removes the old v8::kGCCallbackFlagForced from Heap::CollectAllAvailableGarbage. > > BUG=591463 > LOG=Y > > Committed: https://crrev.com/2436674c97f9e0bbc46a4bd75317e6470b4e720d > Cr-Commit-Position: refs/heads/master@{#34517} TBR=jochen@chromium.org,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591463 Committed: https://crrev.com/30164dc028ff333028df1810af674338fb98cd61 Cr-Commit-Position: refs/heads/master@{#34520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Hablich
Created Revert of Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage
4 years, 9 months ago (2016-03-07 09:47:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771753002/1
4 years, 9 months ago (2016-03-07 09:47:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 09:47:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30164dc028ff333028df1810af674338fb98cd61 Cr-Commit-Position: refs/heads/master@{#34520}
4 years, 9 months ago (2016-03-07 09:48:27 UTC) #5
haraken
4 years, 9 months ago (2016-03-07 10:35:06 UTC) #6
Message was sent while issue was closed.
LGTM, I'll take a look.

Powered by Google App Engine
This is Rietveld 408576698