content/browser/push_messaging/push_messaging_message_filter.cc - Issue 1771743002: Move geolocation and permission mojoms into WebKit/public/platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 1771743002: Move geolocation and permission mojoms into WebKit/public/platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/geolocation/geolocation_service_context.h ('K') | « content/browser/permissions/permission_service_impl.cc ('k') | content/child/permissions/permission_dispatcher.h » ('j') | third_party/WebKit/public/platform/modules/permissions/permission.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_message_filter.cc

diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc

index a2eb8959eeef2e006ce40bbf68fc73b0a89f7182..75c4b1c53cd1bbd7a06ebc4aa37adc3a2e6473ce 100644

--- a/content/browser/push_messaging/push_messaging_message_filter.cc

+++ b/content/browser/push_messaging/push_messaging_message_filter.cc

@@ -148,7 +148,7 @@ class PushMessagingMessageFilter::Core {

// Private Register methods on UI thread -------------------------------------

void DidRequestPermissionInIncognito(const RegisterData& data,

- PermissionStatus status);

+ blink::mojom::PermissionStatus status);

void DidRegister(const RegisterData& data,

const std::string& push_registration_id,

@@ -455,10 +455,10 @@ void PushMessagingMessageFilter::Core::RegisterOnUI(

void PushMessagingMessageFilter::Core::DidRequestPermissionInIncognito(

const RegisterData& data,

- PermissionStatus status) {

+ blink::mojom::PermissionStatus status) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Notification permission should always be denied in incognito.

- DCHECK_EQ(PermissionStatus::DENIED, status);

+ DCHECK_EQ(blink::mojom::PermissionStatus::DENIED, status);

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE,

base::Bind(&PushMessagingMessageFilter::SendSubscriptionError, io_parent_,