Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: content/browser/permissions/permission_service_impl.h

Issue 1771743002: Move geolocation and permission mojoms into WebKit/public/platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/permissions/permission_service_impl.h
diff --git a/content/browser/permissions/permission_service_impl.h b/content/browser/permissions/permission_service_impl.h
index 098a9e3664c5ff113a4732a22b4484c4a09e0848..fdae0fad468af0fb5db4df7de9cfb33a1d525d70 100644
--- a/content/browser/permissions/permission_service_impl.h
+++ b/content/browser/permissions/permission_service_impl.h
@@ -9,8 +9,8 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "content/browser/permissions/permission_service_context.h"
-#include "content/common/permission_service.mojom.h"
#include "mojo/public/cpp/bindings/binding.h"
+#include "third_party/WebKit/public/platform/modules/permissions/permission.mojom.h"
namespace content {
@@ -23,7 +23,7 @@ enum class PermissionType;
// to have some information about the current context. That enables the service
// to know whether it can show UI and have knowledge of the associated
// WebContents for example.
-class PermissionServiceImpl : public PermissionService {
+class PermissionServiceImpl : public blink::mojom::PermissionService {
public:
~PermissionServiceImpl() override;
@@ -35,13 +35,15 @@ class PermissionServiceImpl : public PermissionService {
protected:
friend PermissionServiceContext;
- PermissionServiceImpl(PermissionServiceContext* context,
- mojo::InterfaceRequest<PermissionService> request);
+ PermissionServiceImpl(
+ PermissionServiceContext* context,
+ mojo::InterfaceRequest<blink::mojom::PermissionService> request);
private:
- using PermissionStatusCallback = mojo::Callback<void(PermissionStatus)>;
+ using PermissionStatusCallback =
+ mojo::Callback<void(blink::mojom::PermissionStatus)>;
using PermissionsStatusCallback =
- mojo::Callback<void(mojo::Array<PermissionStatus>)>;
+ mojo::Callback<void(mojo::Array<blink::mojom::PermissionStatus>)>;
struct PendingRequest {
PendingRequest(const PermissionsStatusCallback& callback,
@@ -56,7 +58,8 @@ class PermissionServiceImpl : public PermissionService {
using RequestsMap = IDMap<PendingRequest, IDMapOwnPointer>;
struct PendingSubscription {
- PendingSubscription(PermissionType permission, const GURL& origin,
+ PendingSubscription(PermissionType permission,
+ const GURL& origin,
const PermissionStatusCallback& callback);
~PendingSubscription();
@@ -68,48 +71,49 @@ class PermissionServiceImpl : public PermissionService {
};
using SubscriptionsMap = IDMap<PendingSubscription, IDMapOwnPointer>;
- // PermissionService.
- void HasPermission(PermissionName permission,
+ // blink::mojom::PermissionService.
+ void HasPermission(blink::mojom::PermissionName permission,
const mojo::String& origin,
const PermissionStatusCallback& callback) override;
- void RequestPermission(PermissionName permission,
+ void RequestPermission(blink::mojom::PermissionName permission,
const mojo::String& origin,
const PermissionStatusCallback& callback) override;
- void RequestPermissions(mojo::Array<PermissionName> permissions,
+ void RequestPermissions(mojo::Array<blink::mojom::PermissionName> permissions,
const mojo::String& origin,
const PermissionsStatusCallback& callback) override;
- void RevokePermission(PermissionName permission,
+ void RevokePermission(blink::mojom::PermissionName permission,
const mojo::String& origin,
const PermissionStatusCallback& callback) override;
void GetNextPermissionChange(
- PermissionName permission,
+ blink::mojom::PermissionName permission,
const mojo::String& origin,
- PermissionStatus last_known_status,
+ blink::mojom::PermissionStatus last_known_status,
const PermissionStatusCallback& callback) override;
void OnConnectionError();
- void OnRequestPermissionResponse(
- int pending_request_id,
- PermissionStatus status);
+ void OnRequestPermissionResponse(int pending_request_id,
+ blink::mojom::PermissionStatus status);
void OnRequestPermissionsResponse(
int pending_request_id,
- const std::vector<PermissionStatus>& result);
-
- PermissionStatus GetPermissionStatusFromName(PermissionName permission,
- const GURL& origin);
- PermissionStatus GetPermissionStatusFromType(PermissionType type,
- const GURL& origin);
+ const std::vector<blink::mojom::PermissionStatus>& result);
+
+ blink::mojom::PermissionStatus GetPermissionStatusFromName(
+ blink::mojom::PermissionName permission,
+ const GURL& origin);
+ blink::mojom::PermissionStatus GetPermissionStatusFromType(
+ PermissionType type,
+ const GURL& origin);
void ResetPermissionStatus(PermissionType type, const GURL& origin);
void OnPermissionStatusChanged(int pending_subscription_id,
- PermissionStatus status);
+ blink::mojom::PermissionStatus status);
RequestsMap pending_requests_;
SubscriptionsMap pending_subscriptions_;
// context_ owns |this|.
PermissionServiceContext* context_;
- mojo::Binding<PermissionService> binding_;
+ mojo::Binding<blink::mojom::PermissionService> binding_;
base::WeakPtrFactory<PermissionServiceImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(PermissionServiceImpl);

Powered by Google App Engine
This is Rietveld 408576698