chrome/browser/permissions/permission_uma_util.cc - Issue 1771743002: Move geolocation and permission mojoms into WebKit/public/platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1771743002: Move geolocation and permission mojoms into WebKit/public/platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_manager_unittest.cc ('k') | chrome/browser/push_messaging/push_messaging_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 4a3f649c8d67a512548806aa8736de0876f2a05c..a936af7c7e98201dcf1466a95732a7cdc2fa3c13 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -228,15 +228,15 @@ void RecordPermissionRequest(PermissionType permission,

content::PermissionManager* manager = profile->GetPermissionManager();

if (!manager)

return;

- content::mojom::PermissionStatus embedding_permission_status =

+ blink::mojom::PermissionStatus embedding_permission_status =

manager->GetPermissionStatus(permission, embedding_origin,

embedding_origin);

base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(

"Permissions.Requested.CrossOrigin_" +

PermissionUtil::GetPermissionString(permission),

- 1, static_cast<int>(content::mojom::PermissionStatus::LAST),

- static_cast<int>(content::mojom::PermissionStatus::LAST) + 1,

+ 1, static_cast<int>(blink::mojom::PermissionStatus::LAST),

+ static_cast<int>(blink::mojom::PermissionStatus::LAST) + 1,

base::HistogramBase::kUmaTargetedHistogramFlag);

histogram->Add(static_cast<int>(embedding_permission_status));

} else {