Change type of touch selection handles to POPUP

ui/views/touchui/touch_selection_controller_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_
 #define UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_
 
 #include "base/timer/timer.h"
 #include "ui/base/touch/touch_editing_controller.h"
 #include "ui/gfx/point.h"
@@ skipping 59 matching lines @@
 
   void StartContextMenuTimer();
 
   // Convenience method to update the position/visibility of the context menu.
   void UpdateContextMenu(const gfx::Point& p1, const gfx::Point& p2);
 
   // Convenience method for hiding context menu.
   void HideContextMenu();
 
   // Convenience methods for testing.
+  gfx::NativeView GetCursorHandleNativeView();

[sadrul, 2014/03/14 18:30:07]

Hm. These are used in TouchSelectionControllerImplTest, which is already a
friend of this class. Can we remove these test methods from here, and move their
implementations in the corresponding methods of TSCImplTest?

[mohsen, 2014/03/14 19:15:25]

Since EditingHandleView class is forward-declared in this header file and
declared in the .cc file, its declaration is not available in TSCImplTest and we
can't access its members there (or anywhere else other than TSCI.cc). So, these
methods are not actually 'convenience' methods!

   gfx::Point GetSelectionHandle1Position();
   gfx::Point GetSelectionHandle2Position();
   gfx::Point GetCursorHandlePosition();
   bool IsSelectionHandle1Visible();
   bool IsSelectionHandle2Visible();
   bool IsCursorHandleVisible();
 
   ui::TouchEditable* client_view_;
   Widget* client_widget_;
   scoped_ptr<EditingHandleView> selection_handle_1_;
@@ skipping 26 matching lines @@
   ViewsTouchSelectionControllerFactory();
 
   // Overridden from ui::TouchSelectionControllerFactory.
   virtual ui::TouchSelectionController* create(
       ui::TouchEditable* client_view) OVERRIDE;
 };
 
 }  // namespace views
 
 #endif  // UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_